Repository navigation
Conversation
Contributor
Author
|
CI (naturally) fails because the docker compose file now references an unreleased PHP REST API. |
PGijsbers
marked this pull request as ready for review
October 21, 2026 07:58
It doesn't work well with `--wait`.
PGijsbers
commented
Oct 21, 2026
| while [ "$ELAPSED" -lt "$TIMEOUT" ]; do | ||
| RESPONSE=$(curl -sS "http://localhost:8000/api/v1/xml/run/${RUN_ID}") | ||
|
|
||
| if echo "$RESPONSE" | grep -q "area_under_roc_curve"; then |
Contributor
Author
There was a problem hiding this comment.
See CI failure. It looks like there may have been a long response from the REST API so that grep exited before echo is finished (similar to this). The use of a here-string should alleviate this.
PGijsbers
force-pushed
the
fix-24
branch
2 times, most recently
from
October 22, 2026 07:05
d3e3883 to
46172c8
Compare
Contributor
Author
|
I restored the profiles, I'll have a look at that in a separate PR. |
josvandervelde
left a comment
josvandervelde
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Just 2 small points
josvandervelde
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #24.
Introduce a separate elastic search indexing job which makes it possible/easy to better distinguish whether the PHP REST API is needed with or without ES support. The new default is to avoid starting and indexing elasticsearch if it is not strictly needed.
As a result, you can now e.g., start the PHP REST API without Elasticsearch:
docker compose up php-api -d.But starting the frontend will still trigger Elasticsearch indexing before start:
docker compose up nginx frontend -d