Repository navigation
Conversation
|
📄 Editor's Copy preview Preview of 479d69a; updated on every push. For review only — the official specifications are published at https://openid.net/specs/ |
There was a problem hiding this comment.
We need to update the definition of 'allow_multiple' - it currently says "Allow returning multiple credentials of the same type" and my presumption is with this change you end up allowing any of the types in the array. (This falls out of it being semantically equivalent to the longer form non-array form of repeating the query.)
Note this will clash with #57 - we could use stacked PRs here: https://docs.github.com/en/pull-requests/how-tos/stacked-pull-requests (i.e. built on top of my branch, and assuming mine is merged first GitHub should auto retarget yours to main when mine is merged). The a query matches credentials whose docType or vct "is identical to the requested value" in mine will need to be updated too.
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk> Co-authored-by: Oliver Terbu <o.terbu@gmail.com>
|
Not sure what gh did from committing a 2 word change (via UI suggestions in gh) to creating a 1200 line commit that doesn't change anything but 2 words... I'll force push remove the last commit if this doesn't fix itself |
3b3211d to
a9ce0fc
Compare
jogu
left a comment
jogu
left a comment
There was a problem hiding this comment.
LGTM , two very editorial nits.
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Co-authored-by: Martijn Haring <62745275+martijnharing@users.noreply.github.com>
|
As discussed on this Monday's call - we have sufficient approvals to merge this, have discussed this on several calls, and all comments have been resolved - we plan to merge it on Monday next week. Any final comments welcome. |
PR #61 turned CredentialQuery.credential_type into the credential_types array. Update the format definition requirements and the mdoc and SD-JWT VC credential type sections to describe matching per entry.
|
Discussion on call: WG confirms ready to merge |
Closes #46