[Dhwaani]

Change the naming convention to snake case

closes #58

[andrewhughes3000]

Issue #58

[awoie]

@Dhwaani could you update this PR to implement the decision recorded in #58 ?

[Dhwaani]

@awoie Sure

[awoie]

@Dhwaani Thanks for working on this! It looks like there are several other places where this same fix needs to be applied. Do you think you'll have the capacity to take those on as well? If your hands are full, no worries at all, just let us know so we can see if another volunteer can help loop in and finish it up.

The following is an overview of needs to change:

scenario_setss are carried as a map in RequestPayload, keyed directly by ScenarioRef, so the scenario_ref field is the map key rather than an item inside the structure.

Proposed:

ScenarioSet structures are carried in the scenario_sets map of RequestPayload, keyed by ScenarioRef, so the scenario_ref field is the map key rather than an item inside the structure.

Reason: ScenarioSet is the structure (CamelCase), scenario_sets the field (snake_case) per #58. A plural "s" after a code span reads as a typo.

Also the following CDDLs need to be updated:

The CDDLs still have the old names. Table and CDDL must match.

ScenarioSets: 1 => { + ScenarioRef => ScenarioSet },

Proposed:

scenario_sets: 1 => { + ScenarioRef => ScenarioSet },

Same here:

CredentialQueries (field table, CDDL, and two mentions under Credential Response)

Proposed:

credential_queries

Reason: same rule as scenario_sets.

General

• What still needs to be done in this PR: type names generalExtensions, formatExtensions, mdocExtensions, sdjwtExtensions, zkFormatExtensions (should be CamelCase) and fields sd-jwt_alg_values, kb-jwt_alg_values (hyphens).

[awoie]

Closing this PR in favor of #73

[awoie]

Duplicate, closing this in favor of #73