Repository navigation
[S2S] Update identifier model names as agreed - #810
Open
GarethCOliver wants to merge 2 commits into
Open
GarethCOliver wants to merge 2 commits into
GarethCOliver wants to merge 2 commits into
Conversation
Align all JSON properties and schema fields in the S2S specification to snake_case, matching OpenID4VCI and OAuth/OIDC conventions, and update corresponding references in text and diagrams. Also unifies names used for the same concept across endpoints: - Supplement request: verification_data_payload -> verification_data - Get Credential request: client_encrypted_data -> client_encrypted_payload Fixes openid#791
…stance_id -> credential_id (openid#762) Per WG decision on openid#762: - Rename `session_id` to `wallet_id`: it is not ephemeral and not a session, but a Wallet-Server-generated identifier for a Wallet Client Instance at an Issuer (analogous to a dynamically established `client_id`). - Rename `credential_instance_id(s)` to `credential_id(s)` and the Provision Credential response `credential_instances` to `provisioned_credentials`, removing the word "instance". - Update Terminology (new `Wallet Identifier (wallet_id)` and `Credential Identifier (credential_id)` definitions) and rewrite the Identifier Model section with the agreed definitions and uniqueness rules. - Rename the "Session Establishment" heading to "Wallet Identifier Establishment" and update prose, tables and sequence diagrams. `verification_id` and `credential_configuration_id` are unchanged.
GarethCOliver
force-pushed
the
s2s-762-identifier-model
branch
from
October 13, 2026 12:57
a6a1fd5 to
c022202
Compare
Collaborator
|
discussed today. Needs more review, but also on the call folks felt it was fine to merge in spite of |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the identifiers as agreed in #762.
Session Id -> Wallet Id
Credential Instance Id -> Credential Id (aligning with canonical OpenId4VCI)