Repository navigation
Conversation
kolyshkin
reviewed
Oct 19, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
nit: you need to fix your commit message (to fit in the standard 80 columns).
otherwise LGTM
OCI requires the runtime to run every poststop hook, even if an earlier hook fails. Keep the existing fail-fast behavior for all other hook types. Fixes: opencontainers#5549 Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
sairex53
force-pushed
the
5549-poststop-continue
branch
from
October 19, 2026 02:08
bc2e290 to
9553b27
Compare
Contributor
Author
Rewrapped the commit message to fit within 80 columns and pushed the updated commit, 9553b27. |
Contributor
|
Closing this PR because this account is engaged in PR farming (see moby/buildkit#7303 (comment) for details). @sairex53 please do not contribute to this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5549.
OCI requires the runtime to run every poststop hook even if an earlier hook fails or times out. Hooks.Run currently returns after the first error, so later cleanup hooks never run.
Continue through the full poststop list and return all hook errors to the caller. Other hook types keep their current fail-fast behavior.
Tests verify that later poststop hooks run after failures, all failures remain discoverable with errors.Is, and prestart hooks still stop on the first error.
Validation: