Repository navigation
Expose the bytes in the SCTP association's own queues and the send buffer that bounds them - #6
Draft
electronicboy wants to merge 2 commits into
Conversation
…ffer that bounds them Syncs jni/libdatachannel to the commit that reports them.
…ands upstream Drop before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the three SCTP stats added in opencollab-incubator/libdatachannel#4 on
SctpStats:sendQueueBytes(): bytes the association has accepted for sending and not had acknowledged, sent or not.DataChannel.bufferedAmount()only counts what usrsctp would not take yet, so up to a whole send buffer (1 MiB by default) waited below it unseen.sendBufferSize(): the bound on that queue, so a reader can tell how full it is and confirmSctpSettings.sendBufferSizetook effect.receiveQueueBytes(): received bytes awaiting reassembly or ordering, the byte counterpart ofpendingChunks().Depends on opencollab-incubator/libdatachannel#4
3e6f753syncsjni/libdatachannelto85e65386, the commit in Report the bytes in the SCTP association's own queues and the send bu… libdatachannel#4.130c1ebpoints.gitmodulesatelectronicboy/libdatachannelso that commit can be fetched meanwhile. It gets dropped once that PR merges, and the submodule is re-synced to the merged commit.Testing
NativeTransportProbenow:sendBufferSize(512 KiB)and assertssendBufferSize()reports exactly 524288;Run locally against an Mbed TLS build of the natives (no OpenSSL headers on that machine): all 15 probe scenarios pass, with peaks of 354–376 KB queued. The OpenSSL-dependent native test executables, the other probes and the release builds were not run locally.