Move examples to opencodeco/validgen-samples - #117
Merged
Merged
Conversation
The _examples programs lived in this module, so their imports were not the ones a caller would write.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The local examples are fully removed and all remaining references consistently point to the verified standalone samples repository.
Review effort: Balanced
Findings: None
What changed in this PR
Moves examples to the standalone opencodeco/validgen-samples module and updates local documentation accordingly.
Changes:
- Removes the
_examplesdirectory. - Links and documents the external samples repository.
- Removes stale internal references to local examples.
| File | Description |
|---|---|
README.md |
Replaces local example instructions with external samples guidance. |
docs/internals.md |
Removes the obsolete example reference. |
testgen/README.md |
Removes _examples from test coverage notes. |
.github/copilot-instructions.md |
Updates repository structure and example location. |
_examples/test01/test01.go |
Removes the same-package example. |
_examples/test01/validator__.go |
Removes generated test01 validation code. |
_examples/test02/test02.go |
Removes the cross-package example command. |
_examples/test02/structsinpkg/mystructs.go |
Removes example structs. |
_examples/test02/structsinpkg/validator__.go |
Removes generated test02 validation code. |
_examples/test03/test03.go |
Removes the range-validation example. |
_examples/test03/validator__.go |
Removes generated test03 validation code. |
_examples/email_test/test_email.go |
Removes the email-validation example. |
_examples/email_test/validator__.go |
Removes generated email validation code. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_examplesfrom this module.github.com/opencodeco/validgen/typesfrom generated code, and imports the package that owns the structs.Fixes #42
Test plan
buildpassesgo test ./...passes in opencodeco/validgen-samples