Repository navigation
Add keys and endkeys for map keys - #115
Merged
Merged
Conversation
Plain dive still checks map values. keys must follow dive on a map, and endkeys closes that key block.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It rejects multidimensional keys nesting explicitly required by issue #48.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds map-key validation via dive,keys,...,endkeys, including analyzer, generator, documentation, and tests.
Changes:
- Registers and parses
keys/endkeys. - Generates validation for scalar map keys and values.
- Adds unit and end-to-end coverage.
| File | Description |
|---|---|
README.md |
Documents map-key validation. |
docs/internals.md |
Describes internal key handling. |
internal/analyzer/analyzer.go |
Analyzes key/value validation blocks. |
internal/analyzer/dive_test.go |
Tests key-block analysis. |
internal/analyzer/operations/operations_list.go |
Registers the new operations. |
internal/analyzer/operations/operations_test.go |
Tests operation metadata. |
internal/analyzer/parser_validation_test.go |
Tests tag parsing. |
internal/codegenerator/build_validator.go |
Generates key/value loops. |
internal/codegenerator/dive_test.go |
Tests generated map-key validation. |
internal/common/dive.go |
Extracts scalar map-key types. |
internal/common/dive_test.go |
Tests map-key extraction. |
internal/parser/dive_test.go |
Tests map-key type parsing. |
tests/endtoend/dive.go |
Adds end-to-end key scenarios. |
tests/endtoend/validator__.go |
Updates generated validator fixture. |
Files not reviewed (1)
- tests/endtoend/validator__.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48