Repository navigation
Add the dive tag for slice, array, and map elements - #114
Merged
Merged
Conversation
Tags after dive apply to each slice, array, or map value, including nested structs the generator already knows. keys and endkeys stay unsupported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diveapplies the tags after it to each slice element, array element, or map value. Tags before it stay on the collection.[]*Addresswithrequired,dive,requiredchecks a non-empty slice, non-nil pointers, andAddressfields. A slice of structs with onlyrequireddoes not walk the elements.keysandendkeysstay unsupported. Nested arrays, pointer mixes the type encoding cannot tell apart, andin/ninon a slice of pointers are rejected.Fixes #7
Test plan
go teston parser, analyzer, common, and codegeneratormake unittestsmake endtoendtestscovers a slice of structs, a map value, a slice that does not dive, and[]*Addressbuildis green