fix(ci): Publish features with the package PAT - #8
Merged
Merged
Conversation
The surviving GHCR package rejects the workflow token. The publish action reads GITHUB_TOKEN from the step environment, so point that at the refreshed GH_TOKEN secret.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted token change matches devcontainers/action@v1 authentication behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Features publishing to authenticate with the package PAT.
Changes:
- Sets
GITHUB_TOKENtosecrets.GH_TOKEN. - Preserves existing publish triggers, guard, and permissions.
| File | Description |
|---|---|
.github/workflows/features.yml |
Uses the PAT for Features publishing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secrets.GH_TOKENagain.devcontainers/action@v1has nogithub-tokeninput; it authenticates withprocess.env.GITHUB_TOKEN, which this step already sets.mainref guard,workflow_dispatch, and the existingcontents: write/packages: writejob permissions from fix(ci): Trim Features permissions and allow manual publish #7. The PAT publishes the package; the job token still needs contents access for checkout.Why
The
opencodeco/devcontainerspackage was deleted, butinstall-php-extensionscannot be deleted because a public version has more than 5,000 downloads. That surviving package has no Actions write ACL forGITHUB_TOKEN. The repositoryGH_TOKENsecret was refreshed withwrite:packages.Test plan
mainpublishesghcr.io/opencodeco/devcontainers/install-php-extensionswithout a 401 or auth-challenge failure