Skip to content

chore(ci): Check feature manifests and shell scripts - #4

Merged
leocavalcante merged 1 commit into
mainfrom
ci/feature-checks
Sep 29, 2026
Merged

leocavalcante merged 1 commit into
mainfrom
ci/feature-checks

Conversation

@leocavalcante

Copy link
Copy Markdown
Member

Summary

  • .github/workflows/ci.yml runs on pull requests and on pushes to main.
  • It checks each devcontainer-feature.json with jq (id, version, and name), runs shellcheck on features/*/install.sh, and runs bash tests/*.sh when that directory has scripts.
  • main has no shell test yet, so that step exits 0 and prints that tests/ is empty. Publishing stays in .github/workflows/features.yml. This workflow does not build devcontainer images.

Test plan

  • PyYAML loaded .github/workflows/ci.yml
  • jq -e '.id and .version and .name' on features/install-php-extensions/devcontainer-feature.json
  • shellcheck -x features/install-php-extensions/install.sh (Nix nixpkgs#shellcheck)
  • The shell-test step prints No shell tests in tests/. and exits 0
  • The Actions run on this pull request is green, with the same three steps

@leocavalcante leocavalcante added the enhancement New feature or request label Sep 29, 2026
@leocavalcante leocavalcante self-assigned this Sep 29, 2026
@leocavalcante
leocavalcante merged commit 09afa72 into main Sep 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant