Skip to content

fix: Install zip from apt on Debian dev container bases - #3

Merged
leocavalcante merged 3 commits into
mainfrom
fix/install-php-extensions-zip
Sep 29, 2026
Merged

leocavalcante merged 3 commits into
mainfrom
fix/install-php-extensions-zip

Conversation

@leocavalcante

Copy link
Copy Markdown
Member

Summary

  • The feature always ran mlocati/docker-php-extension-installer 2.2.5. That script exits unless docker-php-ext-install and the other official PHP image helpers are on PATH. mcr.microsoft.com/devcontainers/base:bullseye has none of them, so zip never started installing.
  • Official PHP images still use that installer. Debian and Ubuntu images install php-cli and the distro package with apt. zip installs php-zip.
  • Other images fail before the upstream script is downloaded. The error names both supported bases.

Test plan

  • bash tests/install-php-extensions.sh
  • shellcheck on features/install-php-extensions/install.sh and tests/install-php-extensions.sh
  • Build mcr.microsoft.com/devcontainers/base:bullseye with extensions set to zip and confirm php -m lists zip
  • Build an official php image with the same option and confirm the mlocati installer still runs

Fixes #2

@leocavalcante leocavalcante self-assigned this Sep 29, 2026
@leocavalcante leocavalcante added the bug Something isn't working label Sep 29, 2026
@leocavalcante
leocavalcante merged commit 7931dcc into main Sep 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to install zip extension

1 participant