Repository navigation
fix: show complete expanded diagrams on mobile - #289
Merged
Merged
Conversation
Start with the complete diagram visible, using Pele’s existing zoom and pan owner for readable detail. Preserve focus, dismissal, navigation, source fallback and touch targets without changing the diagram engine or font settings. Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Expanding a wide docs diagram on a mobile screen hides its right side instead of showing the complete diagram.
User Impact
Expanded diagrams start fitted to both viewport axes. Zoom, pan and reset make detail reachable without shrinking the source font settings or changing the diagram. Existing desktop expanded sizing is preserved when it fits. Native apps and the Control UI are unchanged.
Why This Change Was Made
The earlier natural-width/forced-minimum layout traded clipping for readable labels. Use the pinned Pele viewer for zoom and pan instead, with one controller retired on close, reopen and navigation. Keep focus trapping, dismissal, theme updates, escaped fallback and source exports. No dependency, configuration or authored-doc changes. Requested by @vincentkoc.
Work sessions
Evidence
Mobile example
The initial image is an overview. Zoom reveals readable detail; fit/reset returns to the complete diagram.
Zoomed detail and desktop context