Skip to content

fix: show complete expanded diagrams on mobile - #289

Merged
roboclaw-bot merged 1 commit into
mainfrom
improve/docs-expanded-mobile-fit
Oct 27, 2026
Merged

roboclaw-bot merged 1 commit into
mainfrom
improve/docs-expanded-mobile-fit

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Expanding a wide docs diagram on a mobile screen hides its right side instead of showing the complete diagram.

User Impact

Expanded diagrams start fitted to both viewport axes. Zoom, pan and reset make detail reachable without shrinking the source font settings or changing the diagram. Existing desktop expanded sizing is preserved when it fits. Native apps and the Control UI are unchanged.

Why This Change Was Made

The earlier natural-width/forced-minimum layout traded clipping for readable labels. Use the pinned Pele viewer for zoom and pan instead, with one controller retired on close, reopen and navigation. Keep focus trapping, dismissal, theme updates, escaped fallback and source exports. No dependency, configuration or authored-doc changes. Requested by @vincentkoc.

Work sessions

Evidence

  • The exact final homepage regression is red on base f8d824b in Chromium and WebKit, and green with the fix. It covers fit, touch zoom, pointer pan, landscape resize, keyboard zoom/reset, focus restoration and clean reopening.
  • Renderer/font/isolation, interaction, analytics and media-scene tests: 22 passed. Final viewport/renderer replay: 4 passed.
  • Chromium production-page visual smoke passed, including themes, dismissal, history and PJAX. The newly added control icons exposed broad SVG selectors; the smoke now selects the actual diagram root.
  • A 30-page preview and syntax/whitespace checks passed. Independent P0–P3 review of the complete change and final desktop-sizing refinement found no actionable findings.
  • The local full publishing shell smoke cannot run against this English-only bounded preview because its required localized pages are absent. Hosted Docs Code CI passed on the exact source head, including the publishing shell and Chromium/WebKit checks; CodeQL passed.

Mobile example

BeforeAfter
Docs mobile expanded diagram beforeDocs mobile expanded diagram after

The initial image is an overview. Zoom reveals readable detail; fit/reset returns to the complete diagram.

Zoomed detail and desktop context

Docs mobile diagram zoomed detail

BeforeAfter
Docs desktop expanded diagram beforeDocs desktop expanded diagram after

Start with the complete diagram visible, using Pele’s existing zoom and pan owner for readable detail. Preserve focus, dismissal, navigation, source fallback and touch targets without changing the diagram engine or font settings.

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
@roboclaw-bot
roboclaw-bot marked this pull request as ready for review October 27, 2026 12:59
@roboclaw-bot
roboclaw-bot requested a review from a team as a code owner October 27, 2026 12:59
@roboclaw-bot
roboclaw-bot merged commit 1d5da4a into main Oct 27, 2026
4 checks passed
@roboclaw-bot
roboclaw-bot deleted the improve/docs-expanded-mobile-fit branch October 27, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant