Repository navigation
fix: expanded diagrams stay readable on narrow screens - #287
Merged
Merged
Conversation
Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Expanded documentation diagrams shrink their labels to a few pixels on narrow screens instead of providing a readable scrollable view.
User Impact
Expanded diagrams retain at least their native label size on mobile, with the full diagram reachable by horizontal scrolling. Source exports, error fallback, keyboard dismissal and focus restoration are unchanged. No documentation content, dependencies or deployment configuration change.
Why This Change Was Made
Use the renderer-owned SVG viewBox width for expansion and override the SVG's inline responsive maximum only inside the dialog. This works with the existing Mermaid renderer and the proposed Pele cutover; no second rendering engine or compatibility adapter is introduced. Requested by @vincentkoc.
Work sessions
Evidence
Before
After