Skip to content

fix: expanded diagrams stay readable on narrow screens - #287

Merged
roboclaw-bot merged 1 commit into
mainfrom
roboclaw/docs-expanded-diagrams-20261027
Oct 27, 2026
Merged

roboclaw-bot merged 1 commit into
mainfrom
roboclaw/docs-expanded-diagrams-20261027

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Expanded documentation diagrams shrink their labels to a few pixels on narrow screens instead of providing a readable scrollable view.

User Impact

Expanded diagrams retain at least their native label size on mobile, with the full diagram reachable by horizontal scrolling. Source exports, error fallback, keyboard dismissal and focus restoration are unchanged. No documentation content, dependencies or deployment configuration change.

Why This Change Was Made

Use the renderer-owned SVG viewBox width for expansion and override the SVG's inline responsive maximum only inside the dialog. This works with the existing Mermaid renderer and the proposed Pele cutover; no second rendering engine or compatibility adapter is introduced. Requested by @vincentkoc.

Work sessions

Evidence

  • Chromium and WebKit generated-page regression: both fail on the base because expansion shrinks the SVG; both pass on this exact head. The test also checks source Markdown, escaped error fallback, horizontal end reachability, the focus trap, Escape and focus restoration.
  • Bounded 30-page real-docs preview passed; inspected the actual home and Gateway architecture pages at 390px. The mobile home diagram went from roughly 5px labels in expansion to its native readable size with scrolling.
  • Fresh independent Codex P0–P3 autoreview: scoped-clean. Syntax and whitespace checks passed.
  • This is the independently useful prerequisite extracted while refining improve: render documentation diagrams with Pele #286. The engine swap remains separate and atomic; improve: render documentation diagrams with Pele #286 is unchanged pending parent coordination.

Before

Expanded home diagram before the sizing repair

After

Expanded home diagram after the sizing repair, scrollable at native size

Co-authored-by: vincentkoc <25068+vincentkoc@users.noreply.github.com>
@roboclaw-bot
roboclaw-bot requested a review from a team as a code owner October 27, 2026 06:40
@roboclaw-bot
roboclaw-bot merged commit fb60b49 into main Oct 27, 2026
4 checks passed
@roboclaw-bot
roboclaw-bot deleted the roboclaw/docs-expanded-diagrams-20261027 branch October 27, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant