Assorted CSS code style improvements - #1669
Merged
Merged
Conversation
The base and .small dropdown menus repeated the same properties; extracted them into a shared mixin. This commit was AI generated
Each td action-icon modifier is now its own sibling selector instead of being nested under one shared block. This commit was AI generated
The stream table wrapper now has its own unique class instead of relying on a 6-level ancestor selector chain. This commit was AI generated
The old float/absolute/negative-margin combo didn't reliably keep the mode row below it from overlapping; a flex row does. This commit was AI generated
The floated cancel/save buttons weren't contained by their parent, collapsing it to zero height; flexbox fixes that. This commit was AI generated
.inline-content, .small-column/.medium-column, .checkbox-container.one-line, and .button-container.float-opposite were never referenced by any component; removed instead of converting them. This commit was AI generated
.tiny-form/.smaller-form/.small-form/.medium-form/.large-form, .add-btn/.circle-btn, .red-btn (its rule stays via .danger-btn), and the .action/.single/.double/.triple/.status-col table-column-width modifiers are never applied by any component - verified via full-codebase search, git history, and checking every "+ Add" button's shared code path. This commit was AI generated
darker-row, event-container, external-link, has-alert, multi-select-search (base rule and the leftover #group-modal reference), no-padding, section-heading, single-btn, text-left/text-right, top-tbl, vertical-resize, wider, and being-dragged (its unused drag-snapshot prop confirmed via _snapshot) are all unreferenced. Also renamed offset-col-2 to offset-col since offset-col-1 (its only sibling) is gone. This commit was AI generated
TableActionDropdown is a bulk-actions menu, not a value-picker dropdown (that's DropDown.tsx/react-select), so the old naming was misleading; renamed .drop-down-container to .action-menu and dropped everything the component never actually applies (.small/.flipped/.active states, unused variables, a stale <a> selector, an inert dropdown-ul class) along with 3 orphaned cross-file overrides in _form.scss and _modal-components.scss that targeted the old class name in contexts the component never renders in. This commit was AI generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts at making our CSS just a little bit simpler, mostly by renaming or simplifying selectors, or just straight up deleting unused ones.
How to test this
Should result in no visual changes, so testing is mostly about checking if the affected components still look the same.
AI Usage
Claude Sonnet 5 was used in finding these.