Fix "for" label in workflow config - #1667
Merged
gregorydlogan merged 1 commit intoSep 10, 2026
Merged
Conversation
Fixes an issue were you could not click on the description of a boolean workflow config in order to toggle it. This was caused by the id being generated again on every rerender, but that does not cause FormikFastField to rerender (which is intentional and good). So we persist the id across rerenders now.
Arnei
force-pushed
the
fix-for-label-in-process-step
branch
from
September 2, 2026 15:05
1d51033 to
5a9055a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1654.
Fixes an issue were you could not click on the description of a boolean workflow config in order to toggle it.
This was caused by the id being generated again on every rerender, but that does not cause FormikFastField to rerender (which is intentional and good). So we persist the id across rerenders now.
How to test this
Can be tested as described in #1654.