Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/modules/common/store/_inverter.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import copy
import logging

from control import data
Expand Down Expand Up @@ -33,10 +34,13 @@ def __init__(self, delegate: LoggingValueStore) -> None:
self.delegate = delegate

def set(self, state: InverterState) -> None:
self._raw_state = state
self.delegate.set(state)

def update(self) -> None:
state = self.fix_hybrid_values(self.delegate.delegate.state)
# Kopie, damit bei ausbleibendem set() (Lesefehler) die Hybrid-Korrektur nicht erneut auf den bereits
# korrigierten Wert angewendet wird.
state = self.fix_hybrid_values(copy.copy(self._raw_state))
self.delegate.set(state)
self.delegate.update()

Expand Down
18 changes: 18 additions & 0 deletions packages/modules/common/store/_inverter_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,21 @@ def test_fix_hybrid_values(params):

# evaluation
assert vars(state) == vars(params.expected_state)


def test_update_without_new_reading_does_not_apply_hybrid_fix_twice():
# setup
data.data.counter_all_data.data.get.hierarchy = HYBRID_HIERARCHY
data.data.bat_data["bat2"] = Mock(spec=Bat, data=Mock(
spec=BatData, get=Mock(spec=Get, currents=[0]*3, power=223, exported=100, imported=200)))
delegate = Mock(delegate=Mock(num=1))
purge = PurgeInverterState(delegate=delegate)
purge.set(InverterState(power=-5786, exported=200))

# execution
purge.update()
purge.update() # Lesefehler: kein erneutes set()

# evaluation
state = delegate.set.call_args.args[0]
assert (state.power, state.exported) == (-6009, 300)
Loading