Fix Minimal-Strom bei An/Aus-Geräten, Standby-Threshold für An/Aus-Verbraucher - #4046
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the five-value return in consumer.py so all branches match the four-value unpacking contract.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates minimum-current handling for on/off consumers based on runtime state.
Changes:
- Adds an
ON_OFFusage grouping. - Centralizes runtime-aware minimum-current calculation.
- Adds parameterized tests for minimum-current behavior.
| File | Summary |
|---|---|
packages/control/consumer/usage.py |
Defines the on/off usage group. |
packages/control/consumer/consumer.py |
Applies dynamic minimum-current logic; one branch still returns five values instead of four, causing ValueError during updates. |
packages/control/consumer/consumer_test.py |
Tests minimum-current behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
changed the title
Comment on lines
+82
to
+85
| if self.data.get.charge_state: | ||
| return get_medium_charging_current(self.data.get.currents) | ||
| else: | ||
| return self._convert_power_to_current(self.data.config.max_power) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Für Geräte, die nur an/aus geschaltet werden können, wird als minimaler Strom für die Regelung der konfigurierte Maximal-Strom verwendet, wenn der Verbraucher nicht in Betrieb ist. Wenn dieser in Betrieb ist, wird der aktuelle Strom verwendet. In der Regelung sind Minimal- und Maximal-Strom gleich.
Als Standby-Threshold in der Anlauferkennung wird für An/Aus-Verbraucher 35 W pro Phase gesetzt. Für stufenlos regelbare Verbraucher wird der Mindeststrom verwendet.