Auswertungen: Namens&Farben-Dict erweitern nicht ersetzen - #4041
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage confirming existing names and colors remain after saving new entries.
Review effort: Lite
Findings: 1
What changed in this PR
Extends measurement-log metadata so names and colors accumulate across entries rather than being replaced.
Changes:
- Preserve existing names and colors.
- Copy SmartHome names before processing.
| File | Summary |
|---|---|
packages/helpermodules/measurement_logging/write_log.py |
Accumulates names/colors and avoids mutating input names. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+171
to
+177
| existing_names.update(new_names) | ||
| content["names"] = existing_names | ||
| existing_colors = content.get("colors") | ||
| if not isinstance(existing_colors, dict): | ||
| existing_colors = {} | ||
| new_colors = get_colors(content["entries"][-1]) | ||
| existing_colors.update(new_colors) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.