Keine Phasenumschaltung: Bugfix Ermittlung der Soll-Phasen vor Ladestart aus Konfig - #4039
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The logic and regression coverage are sound; only a minor test-name typo remains.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Corrects phase selection before charging starts on charge points without phase switching.
Changes:
- Uses configured phases before charging and measured phases afterward.
- Adds regression coverage for both states.
| File | Description |
|---|---|
chargepoint.py |
Adjusts phase-selection timing. |
get_phases_test.py |
Adds regression scenarios. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # die eine Phase weg schalten. | ||
| phases=1, phases_in_use=3, prevent_phase_switch=False, | ||
| imported_since_plugged=1, phase_switch_supported=False, expected_phases=3), | ||
| SetPhasesParams(name="Phase switch not supported by cp, use passed phases after before start", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://paste.openwb.de/8uHBW400vdsMIP3
Wenn vorher ein dreiphasiges Fahrzeug an einem Ladepunkt ohne Umschaltung geladen wurde, wurde bei einem 1p Fahrzeug für die Berechnung der Einschaltschwelle 3p verwendet.