docs: correct the Terminals isolation, context, and settings path notes - #1387
Open
silentoplayz wants to merge 1 commit into
Open
docs: correct the Terminals isolation, context, and settings path notes#1387silentoplayz wants to merge 1 commit into
silentoplayz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five small corrections to the Terminals pages. I checked each one by running the Terminals orchestrator 0.2.3 with Open WebUI 0.11.3 on the Docker backend.
advanced/multi-user.md. The comparison table called the per user containers "fully isolated, separate everything". Files, processes, and resources are separate per user. On the Docker backend, though, every workspace sits on the same Docker network so the orchestrator can reach each one by name. That also lets a workspace reach a port another user's workspace has opened. The table cell, the two sentences that send untrusted deployments to Option 2, and the Option 2 bullets now say so and point mutually untrusted deployments at the Kubernetes backend with a NetworkPolicy. The Docker Backend and Kubernetes Operator links on the page all pointed at the Terminals index with no anchor, so they now go to its Deployment section.orchestration/contexts.md. The temporary chat bullet said a per chat terminal is never listed in the picker. It is listed until the temporary chat exists, and a message sent with it selected fails withTerminal unavailable: Terminal server '<name>' requires a saved chat context. The bullet now describes that. A new bullet notes that a proxy request carrying no chat id, such as a direct API call, lands in the shared workspace even under Per chat. The fallback sentence is scoped to the interface, which always sends the chat id.orchestration/policies.md. The settings path carried an unmatched bold marker and an extra step. It now matches the connecting page,Settings > Admin > Integrations, in the Open Terminal section.tab-deployment/Docker.md. One sentence in the naming paragraph explains the extra container provisioned for user idsystem, which Open WebUI uses to read a policy's tool list and system prompt.orchestration/environment-variables.md. One sentence under the injected resource variables explains why they exist, sincenprocandfreereport the host's cores and memory from inside a capped workspace.Related issue or discussion
No linked issue.
Checklist
Notes for reviewers
Everything was measured on the Docker backend with two users on one instance. Text only, with no visual change.
curl http://<first-user-container>:3000/filereturned a file served by the first user's workspace. On the same workspace,localhost:3000refused the connection, and the first workspace's own API on port 8000 answered 401 without its key.X-Session-Idheader reached the shared workspace while the row was on Per chat.systemworkspace.docker psshowed a container labeled with user idsystem, provisioned when Open WebUI first read the policy's tool list.nprocand the host's total fromfree, while/sys/fs/cgroup/cpu.maxandmemory.maxheld the caps.