fix: preserve valid reviewer coverage during output repair - #587
Draft
zzwong wants to merge 1 commit into
Draft
Conversation
Treat repeated coverage claims as one claim and report out-of-assignment positions safely so correction attempts remain actionable. Keep missing, conflicting, and invalid coverage checks intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve valid review results when coverage lists repeat a file, and make assignment-scope errors easier to correct. In the observed failure, 73 entries represented 71 assigned files. Two duplicate pairs caused the result to be discarded; the retry then lost coverage and introduced an out-of-assignment claim.
Changes
Verification
Live outcome
A scoped local binary completed a live review with valid output from all six reviewers. The repository reviewer reported 71 inspected files, zero skipped files, and zero findings. The replay isolates the decoder repair; the live run demonstrates workflow completion rather than sole causation or guaranteed validation of future output. Application-specific identifiers and evidence are retained privately.
For reproduction, compare the recorded prompt's
assignment.fileswith the corresponding per-reviewer slices and initial structured output. Post-selection expansion precedes reviewer validation-scope construction.Closes #586.