Repository navigation
Add audio ownership and paused loading - #1067
Merged
Merged
Conversation
Validation: inherited work; independent checks pending. Team-Machine-Session: r146738
Validation: existing audio tests passed; Chromium and WebKit ownership and paused-load probes passed. Package typecheck blocked by missing prebuilt CLI module. Team-Machine-Session: r146738
Collaborator
Author
|
iOS validation at 0c96b4a (studio-64, Xcode 27.1, SDK 27.1, fresh clone, arm64 simulator build):
Evidence on studio-64: |
The PR adds the audio-ownership conformance fixture, so nativeCoverage.test.ts regenerates four COVERAGE.md rows (One.FileSystem, One.Audio, useAudioPlayer, useAudioPlayerStatus) with audio-ownership after audio-remote. This applies exactly the rows CI received in runs 40610344922 and 40610344837. Team-Machine-Session: m65071
natew
marked this pull request as ready for review
October 28, 2026 03:28
natew
enabled auto-merge
October 28, 2026 03:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio ownership and paused loading
Managed players can claim the single Now Playing session, allowing apps to crossfade players while remote controls follow the current owner. The global player can prepare at a position while paused, without playing the opening. This prepares the package family for One 2.12.0.
Ownership transfers on a new claim; cleanup only releases the matching owner. Replacing a managed player's source retains its claim. Apps control crossfade timing. Preparing a global player rejects if replaced or stopped; remote commands target the current owner.
Addresses #1065 and #1066.
Validation and remaining work
:one:compileDebugKotlinpassed on the final commit.