Repository navigation
fix(vxrn): distinguish bundle and bytecode preparation in traces - #1064
Merged
Merged
Conversation
Validation: actual handler and response recorder probe, 17 cases including deferred stages and baseline response equivalence; oxfmt and oxlint on both changed paths; git diff --check. No native rerun or timing cause claim. Team-Machine-Session: r134555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retained iOS run 40468313817 times out on the second app boot while the native splash still says “Bundling 0%”. Its response trace cannot distinguish waiting for the dev bundle from preparing Hermes bytecode after that bundle is available.
Add four internal response events to the existing opt-in bundle recorder:
bundle:start,bundle:ready,bytecode:startandbytecode:ready. They use the recorder's existing request ID and timestamps. Without the recorder, no new log output is produced. Bundle generation, bytecode caching, response handling and test assertions stay the same.Validation: the actual extracted handler and actual recorder pass 17 focused cases. These compare baseline response bytes, headers, forwarded errors and timer cleanup with tracing off/on, and hold each awaited stage unresolved to check the boundary markers. Formatting, lint and diff checks pass. The normal commit reported that lefthook was unavailable; no hook pass is claimed.
This is diagnostic coverage for the next natural containing CI run. It does not establish the delay's cause, measure hermesc spawn/exit separately, or claim to repair the failed boot. No native rerun or timeout change.
Independent review: same standing Opus reviewer r136960. Required CI and downstream diagnostics: p110356. No library release is needed for this diagnostic-only change.