Repository navigation
Conversation
…a#779) - Declare prompt_eval_cached_count: Optional[int] = None on BaseGenerateResponse so it is not dropped by Pydantic during parsing of generate and chat responses. - Add unit tests for GenerateResponse and ChatResponse model serialization and client chat parsing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #779 (and #773).
Declares
prompt_eval_cached_count: Optional[int] = NoneonBaseGenerateResponseso that prompt caching metrics returned by the Ollama server on/api/generateand/api/chatare preserved rather than silently dropped by Pydantic during response parsing.Changes
ollama/_types.py, addedprompt_eval_cached_counttoBaseGenerateResponsewith docstring.tests/test_type_serialization.py, added unit testtest_response_prompt_eval_cached_count.tests/test_client.py, added integration testtest_client_chat_with_prompt_eval_cached_count.Validation
pytest tests/.ruff checkpasses cleanly.