Repository navigation
feat: support structured embedding inputs - #776
Open
original4422 wants to merge 1 commit into
Open
original4422 wants to merge 1 commit into
original4422 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the current server's structured
/api/embedinputs through both sync and async clients, preserving text and mixed-batch item boundaries.Media values are caller-supplied base64 strings. The README explains server/model capability requirements; this does not add media loading or make chat models support embeddings.
Related #414.
Evidence
EmbedRequestvalidation before HTTP.After: all 32 embed tests pass against the normal public clients and localhost HTTP fixture.
python -m pytest -q ollama tests: 154 passed.hatch fmt --check -fandhatch fmt --check -l: passed.Merge Danger
Door: two-way.
Blast Radius: validation.
Expands only embed request input types. Media decoding and model compatibility remain server responsibilities; older servers may reject structured inputs.