Skip to content

Tolerate lazy-loaded thumbnails in the image modal tests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malberts merged 1 commit into from
Oct 8, 2026
Merged

Tolerate lazy-loaded thumbnails in the image modal tests #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/phpunit/Unit/ImageModalTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ public function canParseDataProvider(): array
'framed' => false,
],
[],
'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?></span> <div class="thumbcaption"></div></div></span></div>~',
'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?></span> <div class="thumbcaption"></div></div></span></div>~',
'<div class="modal fade" role="dialog" id="bsc_modal_test" aria-hidden="true"><div class="modal-dialog modal-lg"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button></div><div class="modal-body"><img src=TEST_OUTPUT class="img-fluid"></div>'
. '<div class="modal-footer"><a class="btn btn-primary" role="button" href="/File:Serenity.png">Visit Source</a><button type="button" class="btn btn-default" data-bs-dismiss="modal" aria-label="Close">Close</button></div></div></div></div>' . "\n",
],
Expand Down Expand Up @@ -378,7 +378,7 @@ public function canParseDataProvider(): array
'manualthumb' => 'Shuttle.png',
],
[],
'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?></span> <div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge"></a></div></div></div></span></div>~',
'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#bsc_modal_test"><div class="thumbinner" style="width:96px;"><span><img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?></span> <div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge"></a></div></div></div></span></div>~',
'<div class="modal fade" role="dialog" id="bsc_modal_test" aria-hidden="true"><div class="modal-dialog modal-lg"><div class="modal-content"><div class="modal-header"><button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button></div>'
. '<div class="modal-body"><img src=TEST_OUTPUT class="img-fluid"></div><div class="modal-footer"><a class="btn btn-primary" role="button" href="/File:Serenity.png">Visit Source</a><button type="button" class="btn btn-default" data-bs-dismiss="modal" aria-label="Close">Close</button></div></div></div></div>' . "\n",
],
Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/Unit/ImageModalTriggerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public function canParseProvider() {
[
'~<div class="thumb tnone"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#id">~',
'~<div class="thumbinner" style="width:96px;">~',
'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?>~',
'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?>~',
]
],
'framed' => [
Expand Down Expand Up @@ -319,7 +319,7 @@ public function canParseProvider() {
],
[
'~<div class="thumb tleft"><span class="modal-trigger" data-bs-toggle="modal" data-bs-target="#id"><div class="thumbinner" style="width:96px;">~',
'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async" width="94" height="240" class="thumbimage"( /)?>~',
'~<img( alt="")? src="' . $scriptPath . '/images/a/aa/Shuttle.png" decoding="async"( loading="lazy")? width="94" height="240" class="thumbimage"( /)?>~',
'~<div class="thumbcaption"><div class="magnify"><a class="internal" title="Enlarge">~',
]
],
Expand Down
Loading