Repository navigation
Fix transitive form-data security issues with 4.0.6 - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development lockfile still resolved jsdom's
form-datadependency to 4.0.0. Refresh only that dependency to 4.0.6 within jsdom's existing^4.0.0range, including its required transitive dependencies; no overrides, manifest changes or library runtime changes are needed.4.0.6 fixes both predictable multipart boundaries (GHSA-fjxv-7rqg-78g4, fixed in 4.0.4) and multipart field-name/filename CRLF injection (GHSA-hmw2-7cc7-3qxx, fixed in 4.0.6). This supersedes #42, which targeted 4.0.4 using the older dependency tree.
Validation: frozen-lockfile installation and 98 Node/mocked Electron tests passed locally. Targeted checks of the installed 4.0.6 dependency confirm that fixed
Math.randomoutput does not repeat boundaries and CRLF in field names/filenames cannot inject header lines. CI exercises the complete browser and Electron matrix. This affects development dependencies only and requires no npm package release.