Skip to content

fix: report rollout completion in Bindplane status - #151

Merged
jsirianni merged 2 commits into
mainfrom
feat/status-rollout-completion
Nov 19, 2026
Merged

jsirianni merged 2 commits into
mainfrom
feat/status-rollout-completion

Conversation

@jsirianni

Copy link
Copy Markdown
Member

No description provided.

@jsirianni
jsirianni marked this pull request as ready for review November 19, 2026 18:57
@jsirianni
jsirianni force-pushed the feat/status-rollout-completion branch from 787646d to b99ab46 Compare November 19, 2026 19:53
@jsirianni
jsirianni changed the base branch from main to deps/dependabot-rollup November 19, 2026 19:56
Base automatically changed from deps/dependabot-rollup to main November 19, 2026 19:57
@jsirianni
jsirianni requested a review from ssmiller25 November 19, 2026 19:58
- reconcileError: drop a Ready phase to ApplyingChanges when writing
  Ready=False so phase and condition stay consistent; Degraded is kept.
- Only poll an Argo Rollout node when the Rollout watch is not
  registered. Deployments, StatefulSets and the migrate Job are watched
  via Owns and no longer trigger a 30s requeue.
- Ignore status-only updates on the Bindplane For watch so status
  writes do not requeue the CR and bypass the retry backoff. Generation,
  annotation, label, finalizer and deletion changes still reconcile.

Assisted-by: Claude Opus 5.5
@jsirianni
jsirianni force-pushed the feat/status-rollout-completion branch from b99ab46 to 1c9f49d Compare November 19, 2026 19:59
@jsirianni
jsirianni added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 75f07bc Nov 19, 2026
21 checks passed
@jsirianni
jsirianni deleted the feat/status-rollout-completion branch November 19, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants