Repository navigation
fix: report rollout completion in Bindplane status - #151
Merged
Merged
Conversation
jsirianni
marked this pull request as ready for review
November 19, 2026 18:57
ssmiller25
reviewed
Nov 19, 2026
jsirianni
force-pushed
the
feat/status-rollout-completion
branch
from
November 19, 2026 19:53
787646d to
b99ab46
Compare
Assisted-by: Claude Opus 5.5
- reconcileError: drop a Ready phase to ApplyingChanges when writing Ready=False so phase and condition stay consistent; Degraded is kept. - Only poll an Argo Rollout node when the Rollout watch is not registered. Deployments, StatefulSets and the migrate Job are watched via Owns and no longer trigger a 30s requeue. - Ignore status-only updates on the Bindplane For watch so status writes do not requeue the CR and bypass the retry backoff. Generation, annotation, label, finalizer and deletion changes still reconcile. Assisted-by: Claude Opus 5.5
jsirianni
force-pushed
the
feat/status-rollout-completion
branch
from
November 19, 2026 19:59
b99ab46 to
1c9f49d
Compare
ssmiller25
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.