Repository navigation
chore: restore pyright's default exclude list - #94
Merged
Merged
Conversation
exclude = ['.cache'] REPLACED pyright's defaults, un-excluding .venv — the same latent config bug that gave nyxchange-timetable-v2 18k errors (#64 there). With defaults restored, project diagnostics stand at 23 (reported in the follow-up chore); this repo's CI does not run pyright yet, so this is prep for enabling it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same latent config bug as nyxchange-timetable-v2#64:
exclude = [".cache"]replaces pyright's default exclude list (**/node_modules,**/__pycache__,**/.*) — the**/.*entry is what keeps.venvout of analysis.Config-only change (this repo's CI does not run pyright yet). With the fixed config, project diagnostics stand at 23 errors (mostly tests) — filed as a follow-up chore. Latent today, but this repo is the one student apps build on, and pyright is the natural next CI gate after ruff.