Repository navigation
feat(client): accept query= on put/delete/patch like get() - #69
Merged
Merged
Conversation
get() translated query= into session params; the other verbs only
took json=, forcing callers to hand-build URLs when a non-GET
endpoint reads the query string (e.g. campus.auth's DELETE
/auth/v1/connections/{provider}/{integration}/?user_id=...).
query= is optional and defaults to None, so existing calls are
unchanged. Closes #68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68.
CampusRequest.get()translatesquery=intoparams=;put/delete/patchonly tookjson=, so callers hitting a non-GET endpoint that reads the query string had to hand-build URLs (live example in #68: campus.auth's disconnect route readsuser_idfrom the query string only).This adds the same optional
query: JsonDict | None = Nonekwarg to the abstractJsonClientsignatures and theCampusRequestimplementations (params=queryalongsidejson=). Optional and defaulting toNone, so existing call sites are untouched.Tests:
tests/unit/test_json_client_query.pyasserts each verb forwardsqueryas sessionparams(and that omitting it still sendsparams=None). Full suite green (122 tests).