Skip to content

fix(auth): token() passes a relative path — absolute URL was double-prefixed and 404ed live #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nycomp merged 1 commit into from
Oct 2, 2026
Merged

fix(auth): token() passes a relative path — absolute URL was double-prefixed and 404ed live #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions campus_python/auth/v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ def token(
authorization-code session endpoint at /auth/v1/token
(campus/auth/provider.py), whose contract requires code and
redirect_uri and rejects every other grant type (#60).

The path passed to the client is relative (like every other
resource method): CampusRequest._build_url() prepends the
client's base_url itself, so an absolute URL here would be
double-prefixed into `https://host/https://host/...` and 404
against real deployments.
"""
json_body: dict[str, str] = {
"grant_type": grant_type,
Expand All @@ -347,7 +353,7 @@ def token(
)
json_body["refresh_token"] = refresh_token

base_url = self.base_url + self.url_prefix + "/oauth/token"
resp = self.client.post(base_url, json=json_body)
token_path = self.url_prefix + "/oauth/token"
resp = self.client.post(token_path, json=json_body)
resp.raise_for_status()
return campus.model.OAuthToken.from_resource(resp.json())
20 changes: 19 additions & 1 deletion tests/unit/test_oauth_token_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,17 @@ class TestTokenEndpointPath(unittest.TestCase):
authorization-code session endpoint at /auth/v1/token
(campus/auth/provider.py) — whose contract requires code and
redirect_uri and rejects every other grant type (client issue #60).

The path must also be RELATIVE: CampusRequest._build_url() prepends
the client's base_url itself, so an absolute URL here gets
double-prefixed into `https://host/https://host/...` and 404s
against real deployments (client issue #62). The mock client's
base_url is therefore deliberately non-empty in these tests.
"""

def setUp(self):
self.auth, self.client = make_auth()
self.client.base_url = ""
self.client.base_url = "https://campusauth.example.com"
self.client.post.return_value.json.return_value = dict(
RFC_TOKEN_PAYLOAD
)
Expand All @@ -206,6 +212,18 @@ def test_refresh_token_targets_oauth_token_endpoint(self):
self.assertEqual(kwargs["json"]["grant_type"], "refresh_token")
self.assertEqual(kwargs["json"]["refresh_token"], "rt123")

def test_token_path_is_relative_not_double_prefixed(self):
"""Regression (client issue #62): with a non-empty client
base_url, the path handed to the client must stay relative —
building `base_url + url_prefix + "/oauth/token"` produced
`https://host/https://host/auth/v1/oauth/token` (404 live)."""
with patch.dict(os.environ, {"CLIENT_ID": "cid123", "CLIENT_SECRET": "sec123"}):
self.auth.token(grant_type="client_credentials")

args, _ = self.client.post.call_args
self.assertFalse(args[0].startswith(("http://", "https://")))
self.assertEqual(args[0], "/auth/v1/oauth/token")


class TestExpirySecondsAliasRemoved(unittest.TestCase):
"""The legacy `expiry_seconds` alias is gone (campus #659, closing
Expand Down
Loading