Repository navigation
fix(auth): send PATCH for client updates (issue #50) - #51
Merged
Merged
Conversation
Clients.update() sent PUT, but the campus auth server registers client update as PATCH-only and has no PUT routes, so every client update failed with 405 Method Not Allowed. Switches to PATCH and pins the verb and partial-body contract with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
Summary
Clients.update()sent PUT, but the campus auth server registers client update as PATCH-only (campus/auth/routes/clients.py:241) and has no PUT routes at all — everyclients[client_id].update(...)call failed with 405 Method Not Allowed against current campusweekly.This PR switches the verb to PATCH and pins the wire contract with unit tests:
update()sendsPATCH /auth/v1/clients/{client_id}/and never PUT;campus.model.Client.Verification
Impact
Unblocks
campus client update(campus-cli) and the campus-admin clients-page edit action, and is a prerequisite for theredirect_urisregistration work tracked by nyjc-computing/campus#651.