Repository navigation
fix(json_client): import HttpHeader from campus.webauth.models - #101
Merged
Merged
Conversation
campus moves its HTTP header models out of campus.model into the new top-level campus.webauth package. CampusRequest.headers annotates and constructs HttpHeader at class-definition time, so the old campus.model.HttpHeader reference breaks against the updated campus-suite@weekly.
…s-suite The webauth header models only exist from campus#857 onward. Resolve them with a fallback so this client imports against both the locked campus-suite (pre-857) and the updated one, unblocking CI on both sides of the coordinated merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to nyjc-computing/campus#857 (webauth moved out of campus.common to top-level
campus.webauth; header models moved fromcampus.modeltocampus.webauth.models).CampusRequest.headersannotates and constructsHttpHeaderat class-definition time, so the oldcampus.model.HttpHeaderreference raisesAttributeErrorat import against campus-suite@weekly once #857 merges.Merge together with campus#857. Tests: 274 client tests pass against the #857 branch.