Skip to content

Assignments.list passes params= to CampusRequest.get (unexpected kwarg) — TypeError on every filtered list #39

Description

@nycomp

Summary

Assignments.list(created_by=...) (v0.3.0, main 9cd4664) calls self.client.get(self.make_path(), params=params), but CampusRequest.get() accepts query=, not params=. Any filtered list call raises:

TypeError: CampusRequest.get() got an unexpected keyword argument 'params'

campus_python/api/v1/assignments.py:32 is the only params= use in the client; every other call uses query=.

Verified fix

params=params → query=params — validated end-to-end against the dev API from campus-classroom (GET /api/v1/assignments?created_by=... now returns 200 JSON).

Found during campus-classroom's e2e smoke test.

Activity

nycomp commented on Sep 30, 2026

@nycomp
ContributorAuthor

Fixed in 6e0e185 (PR #41), which changed Assignments.list to pass filters via the client's query argument (campus_python/api/v1/assignments.py:32). That commit's message only referenced #38, so this issue was never auto-closed.

Covered by the regression test test_assignments_list_passes_query_argument in tests/unit/test_nested_resources.py, and confirmed there are no other params= call sites in the client. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions