Repository navigation
Conversation
The commit 3d385d3 (pull request nvim-tree#3295) removed `git.setup()` that populated the `git.config.git` table, but didn't replace all uses of `git.config.git` with the new `config.g.git` table. More specifically, it missed `Explorer:reload_git()`, which saw the empty `git.config.git` table and returned prematurely. Fix it by reading the config value from `config.g.git.enable`.
ytret
force-pushed
the
fix-upstream-issue-3366
branch
from
October 18, 2026 12:52
edabd7c to
1a3ccfb
Compare
Author
|
Sorry had a trouble with the GitHub interface |
alex-courtis
requested changes
Oct 18, 2026
alex-courtis
left a comment
Member
There was a problem hiding this comment.
Many thanks for the excellent report/reproducer and contribution.
Good catch identifying that git.config is the incorrect table. I'd be most grateful if you could remove it so that we don't have any future problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3366
Current implementation of
Explorer:reload_git()uses the oldgit.configtable:Its init was removed in 3d385d3 (commit 4146915 within the PR), and it's been empty since then, that's why the
ifbranch is always taken andExplorer:reload_git()returns prematurely.Fix this by using the
config.g.git.enablevalue. No need to check ifconfig.g.gitis defined because it is always set here.make all, the reproduction steps in Tracked file still shown as untracked after git.reload() #3366