Skip to content

preserve window proportions does not apply to vertical splits #2113

Closed
Closed
preserve window proportions does not apply to vertical splits#2113
Labels
bugSomething isn't working

Description

@DylanMartin0930
DylanMartin0930
opened on Apr 8, 2023

Description

when setting preserve_window_proportions to true, it preserves the sizing of horizontal splits only

Neovim version

NVIM v0.10.0-dev-1368+gbc66b755f-Homebrew
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

Macos Ventura 13.3

nvim-tree version

fb65be0

Minimal config

require("nvim-tree").setup({
view = {
preserve_window_proportions = true,
},
}

Steps to reproduce

  1. create vertical split
  2. resize it in any direction
  3. open and close file tree

Expected behavior

expect vertical split to stay the same size after toggling file tree on and off

Actual behavior

toggling file tree on and off causes vertical splits to be resized to be 50/50

Activity

  1. DylanMartin0930
    added
    bugSomething isn't working
    on Apr 8, 2023

  2. alex-courtis commented on Apr 9, 2023

    @alex-courtis
    alex-courtis
    on Apr 9, 2023
    Member
        *nvim-tree.view.preserve_window_proportions*
    Preserves window proportions when opening a file.
    If `false`, the height and width of windows other than nvim-tree will be equalized.
      Type: `boolean`, Default: `false`

    The documentation notes that this applies when opening files (from the tree).

  3. alex-courtis commented on Apr 9, 2023

    @alex-courtis
    alex-courtis
    on Apr 9, 2023
    Member

    A little debugging indicates that resizing is not done when opening the tree when preserve_window_proportions not set.

    It's vim that's doing the resizing, not nvim-tree. You can demonstrate this by opening another vertical split inside a narrow window.

    Take a look at :help wiw and :h wmw to adjust this behaviour.

  4. nvim-tree
    locked and limited conversation to collaborators on Apr 9, 2023
  5. alex-courtis
    converted this issue into a discussion #2116 on Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions