Skip to content

fix(sync-server): thread-safe shutdown and error reporting in SyncMapServicer - #236

Draft
sapkota-aayush wants to merge 1 commit into
numaproj:mainfrom
sapkota-aayush:sync-server-graceful-shutdown-fix
Draft

fix(sync-server): thread-safe shutdown and error reporting in SyncMapServicer#236
sapkota-aayush wants to merge 1 commit into
numaproj:mainfrom
sapkota-aayush:sync-server-graceful-shutdown-fix

fix(sync-server): thread-safe shutdown and error reporting in SyncMap…

4ed0cf5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 31, 2026 in 1s

94.09% (-0.17%) compared to 42f9fbd

View this Pull Request on Codecov

94.09% (-0.17%) compared to 42f9fbd

Details

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.09%. Comparing base (42f9fbd) to head (4ed0cf5).
⚠️ Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
pynumaflow/mapper/_servicer/_sync_servicer.py 73.68% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   94.26%   94.09%   -0.17%     
==========================================
  Files          60       60              
  Lines        2441     2457      +16     
  Branches      124      128       +4     
==========================================
+ Hits         2301     2312      +11     
- Misses        101      104       +3     
- Partials       39       41       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.