Skip to content

fix(pkg): handle null values in property queries #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wozhenbang2004 wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

fix(pkg): handle null values in property queries #10229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eab5cfe
fix(pkg): handle null values in property queries
wozhenbang2004 Nov 5, 2026
0c65bf2
test(pkg): cover null values in property queries
wozhenbang2004 Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/utils/queryable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ const getter = ({ data, key }, { unwrapSingleItemArrays = true } = {}) => {
const maybeIndex = Number(k)
if (Array.isArray(_data) && !Number.isInteger(maybeIndex)) {
_data = _data.reduce((acc, i, index) => {
acc[`${label}[${index}].${k}`] = i[k]
acc[`${label}[${index}].${k}`] = i?.[k]
return acc
}, {})
return _data
} else {
if (!Object.hasOwn(_data, k)) {
if (_data == null || !Object.hasOwn(_data, k)) {
return undefined
}
_data = _data[k]
Expand Down
35 changes: 35 additions & 0 deletions test/lib/commands/pkg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,22 @@ t.test('get', t => {
)
})

t.test('nested arg below a null value', async t => {
const { npm, joinedOutput } = await loadMockNpm(t, {
prefixDir: {
'package.json': JSON.stringify({
name: 'foo',
config: { optional: null },
}),
},
config: { json: true },
})

await npm.exec('pkg', ['get', 'config.optional.enabled', 'config.optional'])

t.strictSame(JSON.parse(joinedOutput()), { 'config.optional': null })
})

t.test('array field', async t => {
const { npm, joinedOutput } = await loadMockNpm(t, {
prefixDir: {
Expand Down Expand Up @@ -274,6 +290,25 @@ t.test('get', t => {
'should print json result containing matching results'
)
})

t.test('get array nested items with a null entry', async t => {
const { npm, joinedOutput } = await loadMockNpm(t, {
prefixDir: {
'package.json': JSON.stringify({
name: 'foo',
targets: [{ name: 'first' }, null, { name: 'third' }],
}),
},
config: { json: true },
})

await npm.exec('pkg', ['get', 'targets.name'])

t.strictSame(JSON.parse(joinedOutput()), {
'targets[0].name': 'first',
'targets[2].name': 'third',
})
})
t.end()
})

Expand Down