Skip to content

chore: drop clinic and weak from node-integration knownFailures (v10 backport) #10227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkolev92 wants to merge 1 commit into
base: release/v10
Choose a base branch
from
Open

chore: drop clinic and weak from node-integration knownFailures (v10 backport) #10227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/node-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,12 @@ jobs:
// this is a manually updated list of packages that we know currently fail
const knownFailures = [
'body-parser', // json parsing error difference
'clinic', // unknown, lots of failures
'ember-cli', // timeout in nodejs ci, one failing test for us that timed out
'express', // body-parser is what actually fails, it's used in a test
'https-proxy-agent', // looks ssl related
'node-gyp', // one test consistently times out
'resolve', // compares results to require.resolve and fails, also missing inspector/promises
'uuid', // tests that crypto.getRandomValues throws but it doesn't
'weak', // doesn't seem to build in node >12
'mkdirp', // failing actions in own repo
'undici', // test failure in node >=18, unable to root cause
]
Expand Down
2 changes: 0 additions & 2 deletions scripts/template-oss/node-integration-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,12 @@ jobs:
// this is a manually updated list of packages that we know currently fail
const knownFailures = [
'body-parser', // json parsing error difference
'clinic', // unknown, lots of failures
'ember-cli', // timeout in nodejs ci, one failing test for us that timed out
'express', // body-parser is what actually fails, it's used in a test
'https-proxy-agent', // looks ssl related
'node-gyp', // one test consistently times out
'resolve', // compares results to require.resolve and fails, also missing inspector/promises
'uuid', // tests that crypto.getRandomValues throws but it doesn't
'weak', // doesn't seem to build in node >12
'mkdirp', // failing actions in own repo
'undici', // test failure in node >=18, unable to root cause
]
Expand Down
Loading