Repository navigation
fix(arborist): preserve unowned global bin links - #10223
Open
harshitdeora wants to merge 1 commit into
Open
harshitdeora wants to merge 1 commit into
harshitdeora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10219.
On POSIX, global uninstall retires paths listed by the package manifest. If a global bin has been redirected to a different package, the uninstall also removes the other package's working command.
Before retiring a POSIX global package, check which listed symlinks point inside its package directory. This preserves links into other packages and regular files. Owned links to missing targets are still retired, and a missing bin path is harmless.
Validation on Linux (WSL2) with Node 24.15.0:
git diff --checkpassed.Local validation covered the affected POSIX path. The full npm test matrix was not run.