Repository navigation
fix(ls): show absolute paths for global links - #10201
Open
ShryukGrandhi wants to merge 1 commit into
Open
ShryukGrandhi wants to merge 1 commit into
ShryukGrandhi wants to merge 1 commit into
Conversation
Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ls -gprints linked packages with a path relative to the globallibdirectory, prefixed with./, e.g.my-pkg@1.0.0 -> ./../../../home/me/my-pkg.That path is awkward to read and isn't usable from wherever the user runs the command.
npm 6 printed the absolute target path here.
Fixes #3752
Changes
lib/commands/ls.js, the human-readable output now prints the link's absoluterealpathwhen--globalis set.Local (non-global) output keeps the existing
./relativeform, so project trees and their snapshots don't change.Testing
ls globaltest.Before the fix the snapshot showed
linked@1.0.0 -> ./../../prefix; after the fix it showslinked@1.0.0 -> {CWD}/prefix.npx tap test/lib/commands/ls.jspasses with 100% coverage oflib/commands/ls.js.npx eslint lib/commands/ls.js test/lib/commands/ls.jsis clean.