Repository navigation
feat: use cli for messages, warnings and errors - #64
Merged
Merged
Conversation
Progress output can now be silenced with suppressMessages(), not only with verbose. Closes #32 Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32.
Errors, warnings and verbose progress output now go through cli, so
suppressMessages()silences progress output as well asverbose.stop(),warning()andmessage()becomecli_abort(),cli_warn()andcli_inform(). rlang is added to Imports becausecli_abort()needs it; ggplot2 already depends on it.checkParameters()andcheckKmArgs()report errors against the calling function (bayesOpt(),addIterations(),updateGP()), not the internal helper.verbose = 2, result tables are sent withmessage()so their layout is kept. The initialization error table usesrlang::abort()for the same reason.print.bayesOpt()stays on stdout.stop()calls inside foreach worker bodies are unchanged.User-visible change: progress output moves from stdout to stderr, so
capture.output()orsink()no longer captures it.Assisted-by: Claude Code