Repository navigation
fix(deps): bridge glob to 14.0.6 on the advisory's range - #26
Merged
Merged
Conversation
nonagenticai-claude
Bot
requested a review
from georgiedekker
as a code owner
November 15, 2026 16:07
GHSA-3g3m-2fjr-6pw4 (medium) covers glob >=9.0.0 <=14.0.1 and no 13.x or 10.x carries a patch. jest 30.5.2 pins glob ^13.0.6 (through @jest/reporters, jest-config and jest-runtime), mocha ^13.0.0 and test-exclude ^10.4.1, so the only route is an override -- the pattern licence-validator#17 and planka#2 already use in this estate. Range-scoped so any future <9 instance stays put; src's earlier bare glob ^10.4.0 override is replaced by the same scoped key. Locks: glob 13.0.7 and the nested 10.5.0 both become 14.0.6; glob 10's dependency chain (jackspeak, foreground-child, cliui, ...) is removed with it and nothing else moves. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: georgiedekker <georgiedekker@gmail.com>
georgiedekker
force-pushed
the
lane/glob-14
branch
from
November 15, 2026 16:10
1d65168 to
78eb045
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bridges
globto 14.0.6 in both npm trees (root andsrc) with a range-scoped override.Why
GHSA-3g3m-2fjr-6pw4(medium, published 2026-10-30) — AbortSignal cancellation bypass allows post-timeout filesystem traversal — coversglob >=9.0.0 <=14.0.1. No 13.x or 10.x release carries a patch; 14.0.6 is the fix. jest 30.5.2 pinsglob ^13.0.6(through @jest/reporters, jest-config, jest-runtime), mocha^13.0.0and test-exclude^10.4.1, so the updater cannot resolve it — an override is the estate's proven route (license-validator#17, planka#2, and this repo's own lane/minimatch-11).The
srctree already carried a bareglob: ^10.4.0override; it is replaced by the same scoped key so both trees use one idiom.Lock diff
glob13.0.7 and the nested 10.5.0 both become 14.0.6; glob 10's dependency chain (jackspeak, foreground-child, @isaacs/cliui, …) is removed with it. No other package moves.The root manifest also gains
"name": "javascript-test-executor": it had none, so npm derived the lock's name from the checkout directory (publicon main — a re-creation artifact;glob-14in a worktree). The lock now records the real package name.Gates (local, on this head)
npm ci·npm run lint(0 errors) ·npm test→ 177/177src:npm ci·npm test→ 177/177npm auditin both trees: the glob advisory is absent. What remains isdeepmerge(low, GHSA-gcqx-w48m-w2h4), whose latest release is itself inside the vulnerable range — no fix exists upstream.npm ls glob --all: 14.0.6, noinvalid.Note: the
srctest script has no--forceExit; its suite leaves a listening socket, so jest does not exit on its own (pre-existing, unrelated to this diff). The local gate usednpm test -- --forceExit.Merging publishes one ghcr image by design.
🤖 Generated with Claude Code