Repository navigation
fix(deps): bridge minimatch to 11.0.8 on the advisory's range - #20
Merged
Merged
Conversation
GHSA-g3hv-75wg-m249 (medium, vulnerable >=7.0.0 <11.0.1, patched 11.0.1) cannot be resolved in range: jest 30.5.2 pulls minimatch ^9.0.4 via glob@10.5.0 and ^10.2.2 via glob@13.0.7/test-exclude, and no 10.x is patched. Dependabot therefore refuses the only path (a jest downgrade) and errors instead of opening a PR, which reds main. The range-scoped override resolves every in-range instance to 11.0.8 and leaves the 3.x instances (eslint 8, @typescript-eslint, mocha) alone, as the advisory does not cover them. Same pattern as license-validator#17 and planka#2. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this exists
mainis red on the Dependabot Updates job (run 43641403770). This is not a test failure: the updater cannot construct the security update it is asked to make, so it errors instead of opening a PR.The advisory
GHSA-g3hv-75wg-m249— medium, published 2026-10-30, "minimatch has potential denial of service via globparts amplification">= 7.0.0, < 11.0.1; first patched 11.0.1The change
in both npm projects (
/and/src— independent lockfiles, independent Dependabot jobs). The range-scoped key moves only the instances the advisory covers, so the 3.x minimatch that eslint 8, @typescript-eslint and mocha resolve is untouched.Same pattern already merged in the estate:
license-validator#17(flat override) andplanka#2(this range-scoped form).Lockfile effect (structural diff, no unrelated churn):
minimatch10.2.6 → 11.0.8; the nested 9.0.9 undertest-exclude/globis deduped away;@isaacs/nonrecursive-glob-match(minimatch 11's own dependency) added.Gates run locally, on 11.0.8
npm ci→npm run lint(0 errors, 5 pre-existing warnings) →npm test— 177/177 tests, 19/19 suitessrc:npm ci→ jest with--runInBand --forceExit— 177/177. Thesrcnpm testscript has no--forceExitand hangs on the suite's open handles; that is pre-existing and CI never runs it (the Dockerfile only installs there).npm ls minimatch→ 11.0.8 deduped, noinvalid;npm audit→ no minimatch finding in either tree.Acceptance after merge
The Dependabot Updates job on the new main must conclude
success— a graph-changing push re-runs it (the transitionlicense-validatorsaw after its override merged). That will be verified, not just the PR checks.Notes
npm auditstill listsglob(GHSA-3g3m-2fjr-6pw4, patched 14.0.2) anddeepmerge(low). Neither is in this repo's Dependabot job set (the failing job's only target wasminimatch), so they are out of scope here.🤖 Generated with Claude Code