Repository navigation
fix: clear the 13 high code-scanning alerts - #14
Closed
georgiedekker wants to merge 1 commit into
Closed
georgiedekker wants to merge 1 commit into
georgiedekker wants to merge 1 commit into
Conversation
All 12 open high alerts are scanner false positives or test-only: 11 x py/clear-text-logging-sensitive-data log the opaque secret_config_id reference, never a token value; 1 x py/incomplete-url-substring-sanitization is a unit-test assertion. Each is dismissed on the alert with per-site evidence. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
Author
|
Closed rather than merged: this PR has a 0-file diff. All 12 high alerts were dismissed through the API with per-alert evidence (the CodeQL source is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this lane does
Clears every open high-severity code-scanning alert on
nonagenticai/coding-github.Count note: the repo had 13 open alerts in total — 12 high + 1 medium (
#13 py/stack-trace-exposure,src/routers/github_repo_file_read.py:142). Alerts below high are explicitly out of scope, so #13 is untouched and remains open.No source change was warranted. All 11
py/clear-text-logging-sensitive-dataalerts logsecret_config_id— the opaque secrets-service reference (schemas:pattern ^[a-zA-Z0-9\-_\.]+$,max_length 128, examplerepo-myorg-myproject) — never a token value. CodeQL's own source link for the six resolver alerts is the parameter declaration atsrc/services/secret_resolver.py:32: the rule is firing on the name. Insecret_resolver.pythe token iscombined["GIT_TOKEN"](L80) and is only returned (L86); ingithub_provisioning.pyit is assigned torequest.access_token(L552) or returned in the merged env dict (L891). No log sink receives either. A "fix" here would mean renaming the domain term to dodge the scanner while the same value still reaches the log, so dismissal with per-site evidence is the honest resolution.Alerts and classification
request.secret_config_id(opaque reference); token goes torequest.access_token, never loggedNonebefore any body is readhttpxerror text (request URL only, never the response body)GIT_TOKENexists — no value to leakhttpxerror text (request URL only, never the response body)strip_auth_from_url; the security assertion is L72 (token123not in result)Gate
Run in
.worktrees/scan-highsat this commit:uv run ruff check .uv run ruff format --check .uvx ty@0.0.104 check src(CI-pinned; what the pre-push gate runs)uv run pytestuv run ty check src/with the repo-pinned ty 0.0.39 exits 1 on 14 diagnostics that are pre-existing onmain(unresolved optional importsgit/chardet; PyGithubobjectattribute narrowing). It is not the CI tool: the archetype gate pinsty@0.0.104viauvx, and that passes.Verification
code-scanning/alerts?state=openafter this lane: 1 alert (#13, medium). Open high count: 0. Dismissed: 12.🤖 Generated with Claude Code