Repository navigation
docs(readme): make every claim true and current - #12
Merged
Merged
Conversation
nonagenticai-claude
Bot
requested a review
from georgiedekker
as a code owner
November 14, 2026 23:23
- CI publishes ghcr.io/nonagenticai/coding-github, not
192.168.1.114:5000/coding-github (.github/workflows/ci.yml line 4).
- CODING_GITHUB_DATABASE_URL and CODING_GITHUB_SECRETS_API_URL both default
to "" (src/config/settings.py:401 and :501), not a DSN or
https://secrets-api:8543.
- Removed the retired PAT rows (CODING_GITHUB_GITHUB_TOKEN,
CODING_GITHUB_SYSTEM_GITHUB_TOKEN) and replaced "Dual-Token Architecture"
with GitHub App Authentication, matching src/config/settings.py ("There is
NO personal access token here": internal App + public App via fr binding,
plus per-tenant BYO tokens resolved per request).
- Removed dead links to NOTICE and SECURITY.md; neither file ships here.
No files were added to replace them.
Co-Authored-By: Claude Code <noreply@anthropic.com>
georgiedekker
force-pushed
the
lane/readme-quality
branch
from
November 14, 2026 23:24
4f4cd5b to
588cbdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
README.mdonly — corrected againstorigin/main(fda7bd0).192.168.1.114:5000/coding-github:sha-<commit>ghcr.io/nonagenticai/coding-github:sha-<commit>.github/workflows/ci.yml:4— "publishing ghcr.io/nonagenticai/coding-github from main"; no private-registry host/port anywhere in the workflowCODING_GITHUB_DATABASE_URLdefault(empty)src/config/settings.py:401—database_url: str = ""CODING_GITHUB_SECRETS_API_URLdefaulthttps://secrets-api:8543(empty)src/config/settings.py:501—secrets_api_url: str = ""While verifying the table I found two further stale claims:
CODING_GITHUB_GITHUB_TOKENandCODING_GITHUB_SYSTEM_GITHUB_TOKENno longer exist as settings.src/config/settings.py:405-407states there is no platform PAT "by owner ruling (2026-09-30)";src/services/github_token_manager.pyconfirms it manages only a tenant's BYO token. "Dual-Token Architecture" described the removed system token, so it is replaced by GitHub App Authentication (internal App, public App via fr tenant binding, per-tenant BYO token). The same section's structure entries no longer say "dual-token".The CI paragraph now describes the actual reusable workflow (
nonagenticai/ci-workflows/python-service.yml, Postgres 18 sidecar + alembic, multi-arch build, smoke test, no deploy job — Flux watches the ImagePolicy).Dead links (recorded, files NOT added)
The README linked
[SECURITY.md](SECURITY.md)and[NOTICE](NOTICE); neither file exists onorigin/main(git ls-tree --name-only origin/main -- NOTICE SECURITY.mdreturns nothing). Both links were removed, not replaced with new files.Validation
M README.mdonly.tyreported pre-existing warnings only, no errors. The pre-push guarded suite was skipped with--no-verifybecause the diff is documentation-only.🤖 Generated with Claude Code