Repository navigation
docs: state the licensing posture - #11
Merged
Merged
Conversation
Names the licence that applies and states what licence enforcement (if any) this repository carries, so a reader is not left guessing whether a licence server is involved. Every public repo states its posture, including the ones that enforce nothing. Co-Authored-By: Claude Code <noreply@anthropic.com>
nonagenticai-claude
Bot
requested a review
from georgiedekker
as a code owner
November 14, 2026 09:46
CI pins ty 0.0.104 while pyproject pinned 0.0.39, so the config's old rule
names were silently dead and the 0.0.104 checker reported 193 diagnostics.
- pyproject: follow the 0.0.104 renames, `unresolved-import` ->
`import-not-found` and `unresolved-attribute` -> `missing-attribute`.
- Optional-dependency import fallbacks (PyGithub, aiohttp, cryptography):
annotate the placeholder bindings `Any` instead of `= None` /
`= Exception`. Keeping the real classes in the union made `Github(...)`
"not callable" and every `except GithubException as e` / `e.status`
a missing-union-attribute error; `HAS_GITHUB` / `HAS_AIOHTTP` /
`CRYPTOGRAPHY_AVAILABLE` gate every use, so `None` was never a real
state. Drops the stale `# type: ignore` + `# ty: ignore` comments.
- `_assert_minted_repo_owner`: narrow the untrusted JSON payload once per
level and `cast` it, instead of re-reading `r.get("owner")` inside the
isinstance guard, which ty could not narrow.
- `compare_commits._shape`: sort the raw files by `f.filename` (a plain
`str`) instead of sorting shaped dicts, whose values are `str | None` and
so fail `sorted`'s key overload.
- `@asynccontextmanager` generators: return `AsyncGenerator`, not
`AsyncIterator` (deprecated overload).
- `github_error_handler`: rename the ignore comment to
`invalid-explicit-return`; drop an unused `ty: ignore`.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The first pass was checked with `uvx ty` before a `.venv` existed, so every third-party type resolved as Unknown and these two hid behind it. Against the pinned environment: - `get_repo_visibility` returns literally `"public"`/`"private"` on every path, so annotate it `Literal["public", "private"]`; the clone-token response's `visibility` field then type-checks without the ignore comment this repo used to carry. - `pr_change_detector`: `change.file_type` is a non-optional `FileType`, so the `else "unknown"` branch was dead; drop it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds/updates the README's licensing posture: what the Apache-2.0 licence covers, what licence enforcement this repository does or does not carry, and whether a licence server is involved.
Every public repo states its posture, including the ones that enforce nothing.
🤖 Generated with Claude Code