Skip to content

build: do not pass vendored headers when building against shared libs - #66844

Open
aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:no-vendored-headers
Open

aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:no-vendored-headers

Conversation

@aduh95

@aduh95 aduh95 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

And setup test-shared.yml so we can detect regressions.

This helps detect implicit dependency, and force them to be explicit (hence the changes in binding.gyp files); it can also help detect issues in upstream pkg-configuration (hence the patches I sent to LIEF, uvwasi, and BoringSSL).

And setup `test-shared.yml` so we can detect regressions.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/performance
  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Oct 19, 2026
@github-actions

This comment was marked as duplicate.

@github-actions

This comment was marked as duplicate.

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (e463b48) to head (1840192).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66844      +/-   ##
==========================================
- Coverage   92.85%   90.49%   -2.36%     
==========================================
  Files         428      797     +369     
  Lines      194833   278070   +83237     
  Branches    30108    53424   +23316     
==========================================
+ Hits       180907   251653   +70746     
- Misses      13599    16804    +3205     
- Partials      327     9613    +9286     

see 503 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 510 -> 513 => +3 6 / 513 = 1.1%
aarch64-linux 511 -> 514 => +3 6 / 514 = 1.1%
x86_64-darwin 443 -> 444 => +1 3 / 444 = 0.6%
aarch64-darwin 454 -> 457 => +3 6 / 457 = 1.3%
Total 1918 -> 1928 => +10 21 / 1928 = 1.0%
Changelog
@@ -101,0 +102 @@
+/nix/store/9qnmqyy3a96cxixkh5012vmdx7mmj8mn-boringssl-0.20260929.0 (aarch64-darwin)
@@ -102,0 +104,2 @@
+/nix/store/dqa82pf6zpbya2q5j5y27vqqrw79433a-boringssl-0.20260929.0 (aarch64-linux)
+/nix/store/50qpspny60wkd3n1s34mjj9hphp8lznj-boringssl-0.20260929.0 (x86_64-linux)
@@ -883,11 +886,11 @@
-/nix/store/53zyb0yq6waxdylwb23wq0c8zy4n6v5z-lief-0.17.0 (x86_64-darwin)
-/nix/store/sx2irgyw1pmy0m5jfs4659bzr3l8d9l9-lief-0.17.0-py (x86_64-darwin)
-/nix/store/n9f82msha3pyw7shp8h784pa6hs6yi76-lief-0.17.6 (aarch64-darwin)
-/nix/store/pr5bvzdbxwsckcklb4nl8km15l90z8vc-lief-0.17.6 (aarch64-linux)
-/nix/store/2hba447hn61slp2699rk7rlhwz7kci79-lief-0.17.6 (x86_64-linux)
-/nix/store/868c8b7dav5nv09fzy1qml9v5rfmymxj-lief-0.17.6-dev (aarch64-darwin)
-/nix/store/9kn57nqpgzwyw173x79gig42c1yh1xmp-lief-0.17.6-dev (aarch64-linux)
-/nix/store/snyny6vs7knfyvyb7878ac0qhj7qdsny-lief-0.17.6-dev (x86_64-linux)
-/nix/store/2pld72862iala34h17vpmknd7lrxl3lk-lief-0.17.6-py (aarch64-darwin)
-/nix/store/inlwfl1gihj3yfmdarl77k4isfwmh72h-lief-0.17.6-py (aarch64-linux)
-/nix/store/8vg88dsh62ivjna8gnkmsh2mjc38cgdz-lief-0.17.6-py (x86_64-linux)
+/nix/store/rjz073s4il564r1j3isxf6x5wazsq5fb-lief-0.17.0 (x86_64-darwin)
+/nix/store/hhb0i888m50fd39iqbilq20jrhffl5xp-lief-0.17.0-py (x86_64-darwin)
+/nix/store/xa3m64r3hd3hd94xx7s860dbm7kddkqb-lief-0.17.6 (aarch64-darwin)
+/nix/store/ybs96zgp9inkyfy1gc4w8sp6r1f1w8a4-lief-0.17.6 (aarch64-linux)
+/nix/store/krx0ddl19gcbf385dpwnx3046jf1mfnw-lief-0.17.6 (x86_64-linux)
+/nix/store/dlv3hpnd35jgjv6d9zh661wyyjxihh80-lief-0.17.6-dev (aarch64-darwin)
+/nix/store/mih7xzygrvf4ld5h26s5620kkadf8pm7-lief-0.17.6-dev (aarch64-linux)
+/nix/store/ram0xdb7dlkmrdd3szr9z901b9qnfgzn-lief-0.17.6-dev (x86_64-linux)
+/nix/store/6gi67g13n423gc78g8m96mdb7pi618nn-lief-0.17.6-py (aarch64-darwin)
+/nix/store/7figr257hx5sqx5wkba2pjr2hpylhmg2-lief-0.17.6-py (aarch64-linux)
+/nix/store/0daqisiidmb3qnk8xw9lyckkys857hvy-lief-0.17.6-py (x86_64-linux)
@@ -1833,0 +1837 @@
+/nix/store/9fzzb199bajfljyb67lwydpgnj0sz6js-uvwasi-0.0.23 (aarch64-darwin)
@@ -1834,0 +1839 @@
+/nix/store/8xhg363fjq3sanag6dbrw0q3a8ldgl2x-uvwasi-0.0.23 (aarch64-linux)
@@ -1835,0 +1841 @@
+/nix/store/5ry3inlv2zz640a8wgpg6mxx67gr1mv8-uvwasi-0.0.23 (x86_64-darwin)
@@ -1837,0 +1844,2 @@
+/nix/store/6hklmbp2y9gb9vd0dyhijk257f6iz3xy-uvwasi-0.0.23 (x86_64-linux)
+/nix/store/856zqnlnmvy2phamnjxqmi03dr15p7r7-uvwasi-0.0.23-dev (aarch64-darwin)
@@ -1838,0 +1847 @@
+/nix/store/acck6fyqrpxxdbc9chhcyjx3sxdmszcq-uvwasi-0.0.23-dev (aarch64-linux)
@@ -1839,0 +1849 @@
+/nix/store/0dq16z78w91bcbx9rm0jfy57pjsrxasd-uvwasi-0.0.23-dev (x86_64-linux)

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants