Skip to content

test: run test-config-json-schema in default builds - #66827

Open
marco-ippolito wants to merge 2 commits into
nodejs:mainfrom
marco-ippolito:test-config-json-schema-quic
Open

marco-ippolito wants to merge 2 commits into
nodejs:mainfrom
marco-ippolito:test-config-json-schema-quic

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

test-config-json-schema was skipped unless Node.js was built with QUIC, but doc/node-config-schema.json is generated from a default build, where QUIC is disabled. So the test never ran in CI and the schema was no longer checked.

This skips the test instead when QUIC, DTLS or the V8 sandbox are enabled, or when FFI is disabled, since each of these changes the set of available options. It also removes the dead node_quic check, and compares the schemas with assert.deepStrictEqual() so a failure shows which options differ.

The schema had drifted in the meantime, so this also regenerates it with tools/doc/generate-json-schema.mjs.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.57%. Comparing base (754325c) to head (16fb051).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66827      +/-   ##
==========================================
- Coverage   92.86%   90.57%   -2.29%     
==========================================
  Files         428      797     +369     
  Lines      195085   278221   +83136     
  Branches    30137    53472   +23335     
==========================================
+ Hits       181163   252012   +70849     
- Misses      13595    16575    +2980     
- Partials      327     9634    +9307     

see 503 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito
marco-ippolito force-pushed the test-config-json-schema-quic branch from d51f626 to 8ac821e Compare October 18, 2026 11:48
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 19, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 19, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Oct 19, 2026
@github-actions github-actions Bot removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts with its base branch, removing the author ready label.
Please rebase your branch onto the latest base branch, resolve the conflicts locally, and force-push.
Afterwards the pull request needs a fresh collaborator approval, and a collaborator will add the label back once it is author ready again.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
   ⚠  This PR has conflicts that must be resolved

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66827
�[36m⠋�[39m Loading data for nodejs/node/pull/66827
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66827
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66827
�[36m⠋�[39m Getting comments from nodejs/node/pull/66827
�[36m⠋�[39m Getting commits from nodejs/node/pull/66827
✔  Done loading data for nodejs/node/pull/66827
----------------------------------- PR info ------------------------------------
Title      test: run test-config-json-schema in default builds (#66827)
   ⚠  Could not retrieve the email or name of the PR's author from user's GitHub profile!
Branch     marco-ippolito:test-config-json-schema-quic -> nodejs:main
Labels     test, needs-ci, commit-queue
Commits    2
 - doc: update node-config-schema.json
 - test: run test-config-json-schema in default builds
Committers 1
 - Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66827
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66827
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 18 Oct 2026 09:32:01 GMT
   ✔  Approvals: 2
   ✔  - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/66827#pullrequestreview-5564367071
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66827#pullrequestreview-5576797483
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-10-19T06:46:54Z: https://ci.nodejs.org/job/node-test-pull-request/78474/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78474/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78474/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78474/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Regenerate the schema with tools/doc/generate-json-schema.mjs. It had
fallen out of date because test-config-json-schema was not running in
CI.

Assisted-by: claude:opus-5.5
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
The test was skipped unless Node.js was built with QUIC, but the JSON
schema is generated from a build with the default configuration
options, where QUIC is disabled. As a result the test never ran in CI
and the schema was no longer checked.

Skip the test instead when QUIC, DTLS or the V8 sandbox are enabled,
or when FFI is disabled, since each of these changes the set of
available options. Also remove the check for the `node_quic` variable,
which no longer exists.

Compare the schemas with assert.deepStrictEqual() so that a failure
shows which options differ instead of two long strings.

Assisted-by: claude:opus-5.5
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito
marco-ippolito force-pushed the test-config-json-schema-quic branch from 8ac821e to 16fb051 Compare October 20, 2026 12:22
@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants